From 8f5615a0343367abb1654dcf2119a8cc0ed377b8 Mon Sep 17 00:00:00 2001 From: Emanuele Trabattoni Date: Tue, 22 Jul 2025 11:30:07 +0200 Subject: [PATCH] Lock position fix --- src/remoteIO.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/remoteIO.cpp b/src/remoteIO.cpp index 8f11e58..e88806c 100644 --- a/src/remoteIO.cpp +++ b/src/remoteIO.cpp @@ -22,18 +22,18 @@ remoteIO::~remoteIO() const bool remoteIO::setOut(const channel_t ch, const bool value) { - auto lock = m_bus.getLock(); if (!m_initialized) return false; + auto lock = m_bus.getLock(); LOG_DEBUG("Write Channel", ch, "->", value ? "True" : "False"); return m_bus.writeCoil(m_address, REG_COILS + ch, value); } const bool remoteIO::toggleOut(const channel_t ch) { - auto lock = m_bus.getLock(); if (!m_initialized) return false; + auto lock = m_bus.getLock(); std::vector value; if (!m_bus.readCoils(m_address, REG_COILS + ch, 1, value)) return false; @@ -43,18 +43,18 @@ const bool remoteIO::toggleOut(const channel_t ch) const bool remoteIO::setOutPort(const std::vector values) { - auto lock = m_bus.getLock(); if (!m_initialized) return false; + auto lock = m_bus.getLock(); LOG_DEBUG("Write Port", CH_MAX); return m_bus.writeCoils(m_address, CH_MAX, values); } const bool remoteIO::getOut(const channel_t ch, bool &value) { - auto lock = m_bus.getLock(); if (!m_initialized) return false; + auto lock = m_bus.getLock(); std::vector values; if (!m_bus.readCoils(m_address, REG_COILS + ch, 1, values)) return false; @@ -65,18 +65,18 @@ const bool remoteIO::getOut(const channel_t ch, bool &value) const bool remoteIO::getOutPort(std::vector &values) { - auto lock = m_bus.getLock(); if (!m_initialized) return false; + auto lock = m_bus.getLock(); LOG_DEBUG("Read Port", CH_MAX); return m_bus.readCoils(m_address, REG_COILS, 8, values); } const bool remoteIO::getIn(const channel_t input, bool &value) { - auto lock = m_bus.getLock(); if (!m_initialized) return false; + auto lock = m_bus.getLock(); std::vector values; if (!m_bus.readInputs(m_address, REG_INPUT + input, 1, values)) return false; @@ -87,9 +87,9 @@ const bool remoteIO::getIn(const channel_t input, bool &value) const bool remoteIO::getInPort(std::vector &values) { - auto lock = m_bus.getLock(); if (!m_initialized) return false; + auto lock = m_bus.getLock(); LOG_DEBUG("Read Inputs", CH_MAX); return m_bus.readInputs(m_address, REG_INPUT, CH_MAX, values); }