1
0
mirror of https://gitlab.com/obbart/universal_robots_ros_driver.git synced 2026-04-10 10:00:48 +02:00

Do not use "using namespace" in header files

This commit is contained in:
Felix Mauch
2019-04-10 17:24:34 +02:00
parent fcc1e62ab5
commit 642f040cd8

View File

@@ -33,14 +33,13 @@ namespace ur_driver
{ {
namespace primary_interface namespace primary_interface
{ {
using namespace comm;
class PrimaryParser : public comm::Parser<PackageHeader> class PrimaryParser : public comm::Parser<PackageHeader>
{ {
public: public:
PrimaryParser() = default; PrimaryParser() = default;
virtual ~PrimaryParser() = default; virtual ~PrimaryParser() = default;
bool parse(BinParser& bp, std::vector<std::unique_ptr<URPackage<PackageHeader>>>& results) bool parse(comm::BinParser& bp, std::vector<std::unique_ptr<comm::URPackage<PackageHeader>>>& results)
{ {
int32_t packet_size; int32_t packet_size;
RobotPackageType type; RobotPackageType type;
@@ -66,7 +65,7 @@ public:
} }
// deconstruction of a sub parser will increment the position of the parent parser // deconstruction of a sub parser will increment the position of the parent parser
BinParser sbp(bp, sub_size); comm::BinParser sbp(bp, sub_size);
sbp.consume(sizeof(sub_size)); sbp.consume(sizeof(sub_size));
RobotStateType type; RobotStateType type;
sbp.parse(type); sbp.parse(type);